Skip to content

docs: corrections #14101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

docs: corrections #14101

merged 4 commits into from
Aug 5, 2025

Conversation

DePasqualeOrg
Copy link
Contributor

This PR corrects two grammatical issues:

  • A few instances of a missing hyphen in "server-side rendering"
  • A common mistake in which "as such" is used as a synonym for "therefore", "thus", "so", "this means that", "for this reason", etc.

To illustrate the second issue, this sentence uses "as such" correctly:

reroute is considered a pure, idempotent function. As such, it must always return the same output for the same input and not have side effects.

The rule of thumb is that "such" should be able to be replaced with a noun phrase from the previous sentence:

reroute is considered a pure, idempotent function. As [a pure, idempotent function], it must always return the same output for the same input and not have side effects.

This sentence uses "as such" incorrectly:

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. As such, changes to either condition or color will cause the effect to re-run.

In this case, I've replaced "As such" with "This means that", since "such" does not refer to an aforementioned noun phrase that could logically be the subject of the sentence. "as such" is not a synonym for "this means that":

For instance, if condition is true in the code snippet below, the code inside the if block will run and color will be evaluated. This means that changes to either condition or color will cause the effect to re-run.

Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: d3b8f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann added the documentation Improvements or additions to documentation label Aug 4, 2025
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made the change to the server-side spelling in the error messages too

@eltigerchino eltigerchino merged commit 460108e into sveltejs:main Aug 5, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants