Skip to content

fix: use __SVELTEKIT_PAYLOAD__ to reference boot payload #14127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2025

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 6, 2025

This is an alternative to #14121, which eliminates the (already remote) possibility of race conditions. It does so by making the entire boot payload (the __sveltekit_abc123 = {...} object that exists in the hydration <script>) accessible via a __SVELTEKIT_PAYLOAD__ define.

No test because the failure conditions are quite hard to engineer. But this general approach feels more robust than what we have now, and could enable further simplifications (by reducing the need for virtual modules, etc)

Fixes #14120


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: c2c58bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit e7cd0c2 into main Aug 7, 2025
21 checks passed
@eltigerchino eltigerchino deleted the define-payload branch August 7, 2025 04:08
@github-actions github-actions bot mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single output apps with remote form functions throw an error
2 participants