Skip to content

style(svelte-check): make human output more concise and readable #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style(svelte-check): make human output more concise and readable #2748

wants to merge 1 commit into from

Conversation

YimingIsCOLD
Copy link

This PR makes the human output of svelte-check more concise and readable.

TLDR:

  • Remove ==================================== separator from the output
  • Remove unnecessary leading newlines at the start of the output
  • Trimmed trailing newlines at the end of code blocks when using the --output=human-verbose flag

--output=human

No Errors or Warnings

Before

====================================
svelte-check found 0 errors and 0 warnings

After

svelte-check found 0 errors and 0 warnings

Single Error/Warning

Before

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

====================================
svelte-check found 0 errors and 1 warning in 1 file

After

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

svelte-check found 0 errors and 1 warning in 1 file

Multiple Errors/Warnings

Before

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

/Users/yiming/workspace/somekit/src/routes/+page.svelte:4:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

====================================
svelte-check found 0 errors and 2 warnings in 2 files

After

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

/Users/yiming/workspace/somekit/src/routes/+page.svelte:4:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)

svelte-check found 0 errors and 2 warnings in 2 files

--output=human-verbose

No Errors or Warnings

Before

 
====================================
Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

====================================
svelte-check found 0 errors and 0 warnings

After

Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

svelte-check found 0 errors and 0 warnings

Single Error/Warning

Before

 
====================================
Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;


====================================
svelte-check found 0 errors and 1 warning in 1 file

After

Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;

svelte-check found 0 errors and 1 warning in 1 file

Multiple Errors/Warnings

Before

 
====================================
Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;


/Users/yiming/workspace/somekit/src/routes/+page.svelte:4:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;


====================================
svelte-check found 0 errors and 2 warnings in 2 files

After

Loading svelte-check in workspace: /Users/yiming/workspace/somekit
Getting Svelte diagnostics...

/Users/yiming/workspace/somekit/src/routes/+layout.svelte:10:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;

/Users/yiming/workspace/somekit/src/routes/+page.svelte:4:3
Warn: Unused CSS selector ".container"
https://svelte.dev/e/css_unused_selector (svelte)
<style>
  .container {
    background-color: red;

svelte-check found 0 errors and 2 warnings in 2 files

@YimingIsCOLD
Copy link
Author

Any maintainers can help to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YimingIsCOLD