Skip to content

[fix] reset focus after iframe reload #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[fix] reset focus after iframe reload #159

wants to merge 2 commits into from

Conversation

dummdidumm
Copy link
Member

Fixes #150

@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 11:48AM (UTC)

@Rich-Harris
Copy link
Member

Unfortunately this didn't work for me — you can see in this video I lose focus after let na:

Screen.Recording.2022-12-16.at.10.56.31.AM.mov

Sometimes the focus gets captured by the iframe outside set_iframe_src, in ways that we have no control over. I have a fix that seems to work, will open a new PR

@dummdidumm
Copy link
Member Author

Strange that you get it immediately and I couldn't get it anymore after my testing - but your PR is the more robust solution, so will close in favor of that.

@dummdidumm dummdidumm closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text input focus sometimes lost on rerender/error
2 participants