Skip to content

fix: prevent iframe from reloading when a folder is clicked #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tomoam
Copy link
Contributor

@tomoam tomoam commented Mar 10, 2023

Immediately after opening learn.svelte.dev, if you click on the folder, the iframe will reload.

prevent-iframe-from-reloading.mov

Note that I added expand to status for this fix, but it may not be the proper term (because I couldn't think of a better term with my poor English, sorry...).

@vercel
Copy link

vercel bot commented Mar 10, 2023

@tomoam is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 2:17PM (UTC)

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit bed4f26 into sveltejs:main Mar 10, 2023
@tomoam tomoam deleted the prevent-iframe-from-refreshing-when-folder-is-clicking branch March 12, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants