Skip to content

chore: reset selection color in editor #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

tomoam
Copy link
Contributor

@tomoam tomoam commented Mar 21, 2023

Fixes #279

@vercel
Copy link

vercel bot commented Mar 21, 2023

@tomoam is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@tomoam
Copy link
Contributor Author

tomoam commented Mar 21, 2023

In light mode, this will be fine.
In dark mode, It would still be better to change the background color.

selection-text2

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 3:02AM (UTC)

@Rich-Harris
Copy link
Member

So much better, thank you!

@Rich-Harris
Copy link
Member

(I notice the PR is still in draft, are you planning to fix dark mode in this PR as well?)

@tomoam
Copy link
Contributor Author

tomoam commented Mar 22, 2023

I notice the PR is still in draft, are you planning to fix dark mode in this PR as well?

I've done it. Sorry for the wait.

image

@tomoam tomoam marked this pull request as ready for review March 22, 2023 01:27
@Rich-Harris
Copy link
Member

this looks fantastic, thanks so much!

@Rich-Harris Rich-Harris merged commit 8ef8769 into sveltejs:main Mar 22, 2023
@tomoam tomoam deleted the fix-selection-color branch March 22, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The color of the selected text is white in editor
2 participants