Skip to content

fix: mark function properties on runes as deprecated for better intellisense #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

fix: mark function properties on runes as deprecated for better intellisense #11439

merged 1 commit into from
May 3, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented May 3, 2024 •
edited
Loading

Ensures that IDEs will order them to the bottom so that the rune variants are on top, better visible

closes #11437

kudos to @ottomated and @AdrianGonz97 for the idea!

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: mark function properties on runes as deprecated for better intel…
2cc2e7b 
…lisense

Ensures that IDEs will order the to the bottom so that the rune variants are on top, better visible

closes #11437
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 2cc2e7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 9c5a9d8 into main May 3, 2024
8 checks passed
@dummdidumm dummdidumm deleted the types-runes-dx branch May 3, 2024 08:09
@github-actions github-actions bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svelte5: Improve type definitions for runes
1 participant
@dummdidumm