fix: reset hydrate_node after hydrate(...)
#12512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #12425 (comment) I realised that
hydrate
inside a programmatic snippet currently fails, because we don't resethydrate_node
.This fixes it, and also adds a test showing how to render components in programmatic snippets. (It's fine to call
hydrate
with an emptytarget
— it defers immediately tomount
.)It did force a couple of realisations:
render(Component, {...})
fails in the client — obviously — because it tries to pass the server$$payload
to the client component function that expects an$$anchor
. I wonder ifrender
should instead return a{ head: '', body: '' }
object if it's run in the browser? It would be convenient for this use case, though perhaps surprising for others. (In an ideal world each component would include both client and server code, and we'd somehow treeshake away the stuff we weren't using, but it's not really possible AFAICT.)svelte/environment
module withdev
andbrowser
exports, just like we have in SvelteKit (and in future, it could replace$app/environment
). I tried writing the test with atypeof window
check, but it turns outwindow
is defined in the Vitest environment so it didn't work, and I had to add a mechanism for adding server props to tests insteadBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint