🦋 Changeset detected

Latest commit: d492dc8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Judging from the tests it's impressive how many cases it handles (honestly more than I think we need to), but I'm a bit surprised about all the additional code for Component and SvelteComponent - why do we need to account for slots, comments, the last const binding, etc etc? My (maybe too simplistic) first thought was that we'd call context.next() in the (Svelte)Component visitor first, then remove the this attribute, then replace the svelte:component tags with whatever replacement they need and potentially prepend a @const directly before it. What's the reason this isn't enough?

I was honestly surprised too, the walk was initially just needed to properly replace $$props and $$restProps and most of the complexity came from the LetDirective and the ConstTag...the idea behind last_const_binding was to put the new {@const} tag after the last {@const} tag that was used inside the expression because that's how i would write that code but you are probably right and just writing it right before the svelte:component should solve a lot of headaches. And doing this should also solve the let problem because the whole code in Component was there just to be able to have the correct scope in svelte:component.

I'll try with your suggestion and i'm pretty sure it's simplify-able (that will result in probably a tad uglier code in some cases but i think it's perfectly reasonable).