Skip to content

feat: add migration-task comment after errors #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #13464

I've added a migration task comment at the beginning and since afterUpdate and beforeUpdate was not throwing i added the throw for them too. Since i was at it i thought that sometimes we just left imports lingering there and it would be a shame not migrating an otherwise migratable file just for this so i added a bit of "treeshake" logic to remove the import if it's not used.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: a4be4a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti merged commit 0dcd4f6 into main Oct 18, 2024
9 checks passed
@paoloricciuti paoloricciuti deleted the add-migration-task-on-error branch October 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration: add TODOs to impossible to migrate files
2 participants