fix: reset reset_element
in render
to prevent runtime error
#13669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 5 rewrite
Fixes the problem delineated in #13654...the problem is when you render a snippet that render a component inside an element. This is because the code looks like this
specifically we are
pushing_element
before rendering the snippet and popping the element after. However inside therender
in snippet we dowhich set the parent to
null
...since this is happening within the divpop_element
doesn't find the parent and errors out.The original PR just safe guarded the
parent.parent
access which might be a solution nonetheless? My solution is storing the old parent and restoring it after rendering the component which seems a bit better but i'm not fully aware of the consequences.Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint