Skip to content

fix: css pruning producing invalid css #14448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: css pruning producing invalid css #14448

merged 2 commits into from
Nov 26, 2024

Conversation

paoloricciuti
Copy link
Member

Closes #14426

I think this is a better strategy to keep the commas...before we were adding the comma everytime i was not the last selector but if every other selector is unused we don't need to add the comma or it will produce invalid css.

Instead i moved the logic to keep the previous comma when there's a new used selector that has a previous used selector.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 3a39946

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14448

@Rich-Harris
Copy link
Member

nice, love when the correct code is leaner than the incorrect code

@Rich-Harris Rich-Harris merged commit 19d80ad into main Nov 26, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the css-unused-invalid branch November 26, 2024 21:30
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong unused CSS selector handling when multiple selectors used for one ruleset
2 participants