You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This always bothers me when adding a new warning/error because you have to rerun the dev script to regenerate the messages and if you forget it will also fail lint (since the script it also re-organise them).
This adds a watch mode to the script so that you can just run the dev script and be done with it (i had to do a bit of promise gymnastics because messages it's changing when the script run).
Dunno if we want to merge this but it seems useful.
Before submitting the PR, please make sure you do the following
It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
Prefix your PR title with feat:, fix:, chore:, or docs:.
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.
If this PR changes code within packages/svelte/src, add a changeset (npx changeset).
Tests and linting
Run the tests with pnpm test and lint the project with pnpm lint
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
ah lol whoops! i was being careless and thought it was about preventing multiple runs immediately after each other. I still think we can keep it sync though, and bail out inside the watch callback instead
ah lol whoops! i was being careless and thought it was about preventing multiple runs immediately after each other. I still think we can keep it sync though, and bail out inside the watch callback instead
I tried but the watch callback is not sync so it's invoked a tad later.
It's not sync, but you can reset the guard when it re-runs instead of after calling run() and it seems to work well. Still involves a bit of song and dance but it's more localised hence easier to follow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This always bothers me when adding a new warning/error because you have to rerun the dev script to regenerate the messages and if you forget it will also fail lint (since the script it also re-organise them).
This adds a watch mode to the script so that you can just run the dev script and be done with it (i had to do a bit of promise gymnastics because
messagesit's changing when the script run).Dunno if we want to merge this but it seems useful.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint