Fix use-directives called multiple times #4781
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4693.
Additional remarks:
As far as I can tell, the fix seems to be working fine. I added a new test which covers the problem (thanks @pushkine !) and also thoroughly tested this version in a rather large scale app.
But, as already discussed in the issue, I think @pushkine has a valid point that this should be considered more of a a short-term remedy to address the (potentially huge) memory leak caused by mounting directives over and over. A more thorough approach would be in order in the long run.