-
Notifications
You must be signed in to change notification settings - Fork 10
svelte-subdivide v3 PR #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Perhaps a clearer name is toPOJSO() or to toPOJO() ...?
1 out of 8 tests are passing so far. |
Another bug seems to be in Subdivide.beforeUpdate() { createGroup() } and another in that Subdivide.layout is always set to defaultLayout. |
After the latest commits it's passing 23 out of 24 tests. |
Small woopsie, I bumped the version prematurely accidentally when uploading some changes to package.json |
In test #7, where the layout is passed to the constructor, it's creating the Panes in the wrong order internally, though geometrically everything's fine. It seems one can only tell the difference with static vars, such as the static counter used in the tests that detects instancing order. So it doesn't pass the test, but I'm not sure it would affect proper functioning in the end. Also, I'm not sure I can control instancing order. |
Regarding the new test... something that instantiates a predefined layout and then clicks, creating new panes. |
really hope to see this working with the newest svelte :) |
here is my svelte layout component .... yay repl im using a css flex layout, so its zoom agnostic the goal is to rewrite golden-layout.js in svelte another good example is qt dockable widgets edit: yay github https://github.com/milahu/svelte-layout-resizable |
Not tested yet because compilation is being blocked by an apparent
rollup-plugin-svelte
unexpected 'nowarn' option bug.Just opening the PR to possibly avoid somebody else doing the same work in the meanwhile. I'll add any fixes as soon as I can compile and test the upgrade.
Sorry if there's too much commit noise, I was just making sure I detailed my first foreign upgrade for clarity. Should I collapse it?