fix: layout shift behind command+k search #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! Code looks good though I'll let someone else (@dummdidumm?) approve the PR since as a Mac user this issue doesn't affect me in the first place. (By the same token, I think it's fine that Safari doesn't support this property, because all desktop Safari users are Mac users) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the layout shift behind cmd+k SearchBox when it is toggled on-off. Words in paragraphs jump and images scale.
scrollbar-gutterto the html whenoverflowishiddenby theoverlay_openstore. This allows body size to remain stable.fixedtoabsoluteto account for thescrollbar-gutter.topfrom frozen body to account for the new positioning.topstyle declaration of the body anymore.scrollbar-gutteris not yet supported in Safari, this means the experience is unchanged for Safari users.