a set of extra test cases #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemredkin
approved these changes
Nov 18, 2019
4d588c8 to
ac94cbf
Compare
Motivation: More unit tests are good and now that SwiftNIO shipd `NIOHTTP1TestServer`, writing integration tests for async-http-client is also more straightforward. Modification: Demonstrate some tests using NIOHTTP1TestServer. Result: More tests.
ac94cbf to
39fb12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
More unit tests are good and now that SwiftNIO shipd
NIOHTTP1TestServer, writing integration tests for async-http-client is alsomore straightforward.
Modification:
Demonstrate some tests using NIOHTTP1TestServer.
Result:
More tests.