Deflake HTTP2ConnectionTests/testSimpleGetRequest #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: testSimpleGetRequest asserts right after submitting the request for execution that no streams have been closed. While unlikely there's nothing to prevent this assertion from failing (and indeed it has failed): the request may have executed immediately and the stream closed before checking the delegate. Modifications: - Remove the assertion Result: Tests are less flaky
Lukasa
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
testSimpleGetRequest asserts right after submitting the request for execution that no streams have been closed. While unlikely there's nothing to prevent this assertion from failing (and indeed it has failed): the request may have executed immediately and the stream closed before checking the delegate.
Modifications:
Result:
Tests are less flaky