[stable/20240723] Expose macros for availability domain definitions #11250
+85
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, replace feature-availability.h with availability_domain.h to better align the header/module name with the name of the compiler feature. Resolves rdar://157689733.
|
@swift-ci please test |
tshortli
commented
Aug 23, 2025
| @@ -927,6 +927,8 @@ ASTContext::getFeatureAvailInfo(Decl *D) const { | |||
| auto *Attr = VD->getAttr<AvailabilityDomainAttr>(); | |||
| if (!Attr) | |||
| return {}; | |||
| if (!VD->getInit()) | |||
There was a problem hiding this comment.
This is a drive-by fix for a compiler crash I encountered when testing an earlier version of this PR.
|
@swift-ci please test Windows |
ahatanaka
reviewed
Aug 25, 2025
| @@ -10,24 +10,8 @@ | |||
| #ifndef __FEATURE_AVAILABILITY_H | |||
| #define __FEATURE_AVAILABILITY_H | |||
|
|
|||
| #include <stdint.h> | |||
| // feature-availability.h is deprecated - use availability_domain.h instead. | |||
There was a problem hiding this comment.
Should we turn this comment into a real warning using #warning?
There was a problem hiding this comment.
I'd rather have a chance to move adopters off of it before it becomes a warning (although once adopters move off of it we should probably remove it entirely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #11253.
Also, replace
feature-availability.hwithavailability_domain.hto better align the header/module name with the name of the compiler feature.Resolves rdar://157689733.