[6.2 🍒][Dependency Scanning] Bridge diagnostics emitted during bridging header scanning #81876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er scanning Instead of simply dumping them to stderr. Resolves rdar://151993075
nkcsgexi
approved these changes
May 30, 2025
|
This is to simply adding more diagnostic messages to an already failing build. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #81850
Explanation: The Swift dependency scanner collects diagnostics as it performs a scan, including those emitted by the integrated Clang dependency scanner. Such diagnostics are then presented to the client, most-likely the
swift-driveror another build system. This change adds such diagnostic handling to those emitted by the clang dependency scanner when scanning the bridging header file.Scope: Specifically dependency scanning actions (as part of a build with explicitly-built modules) which involve scanning a bridging header file and emitting diagnostics during said header scan.
Risk: Low, the code-path this changes affects only how Clang scanner-emitted diagnostics are handled by collecting them into the scanner's diagnostic handler, like any other diagnostics, instead of just dumping them to stderr.
Problem: rdar://151993075
Reviewed By: @cachemeifyoucan
Original PR: [Dependency Scanning] Bridge diagnostics emitted during bridging header scanning #81850