Skip to content

Add Hashable conformance to JSObject #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add Hashable conformance to JSObject #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions IntegrationTests/TestSuites/Sources/PrimaryTests/UnitTestUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ func expectEqual<T: Equatable>(
}
}

func expectNotEqual<T: Equatable>(
_ lhs: T, _ rhs: T,
file: StaticString = #file, line: UInt = #line, column: UInt = #column
) throws {
if lhs == rhs {
throw MessageError("Expect to not be equal \"\(lhs)\" and \"\(rhs)\"", file: file, line: line, column: column)
}
}

func expectObject(_ value: JSValue, file: StaticString = #file, line: UInt = #line, column: UInt = #column) throws -> JSObject {
switch value {
case let .object(ref): return ref
Expand Down
19 changes: 19 additions & 0 deletions IntegrationTests/TestSuites/Sources/PrimaryTests/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,4 +746,23 @@ try test("Grow Memory") {
try expectEqual(string, jsString.description)
}

try test("Hashable Conformance") {
let globalObject1 = JSObject.global.console.object!
let globalObject2 = JSObject.global.console.object!
try expectEqual(globalObject1.hashValue, globalObject2.hashValue)
// These are 2 different objects in Swift referencing the same object in JavaScript
try expectNotEqual(ObjectIdentifier(globalObject1), ObjectIdentifier(globalObject2))

let sameObjectSet: Set<JSObject> = [globalObject1, globalObject2]
try expectEqual(sameObjectSet.count, 1)

let objectConstructor = JSObject.global.Object.function!
let obj = objectConstructor.new()
obj.a = 1.jsValue()
let firstHash = obj.hashValue
obj.b = 2.jsValue()
let secondHash = obj.hashValue
try expectEqual(firstHash, secondHash)
}

Expectation.wait(expectations)
10 changes: 10 additions & 0 deletions Sources/JavaScriptKit/FundamentalObjects/JSObject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ extension JSObject: CustomStringConvertible {
public var description: String { self.toString!().string! }
}

extension JSObject: Hashable {
/// Hashes the essential components of this value by feeding them into the
/// given hasher.
///
/// - Parameter hasher: The hasher to use when combining the components
/// of this instance.
public func hash(into hasher: inout Hasher) {
hasher.combine(id)
}
}

/// A `JSObject` wrapper that enables throwing method calls capturing `this`.
/// Exceptions produced by JavaScript functions will be thrown as `JSValue`.
Expand Down