Skip to content

Updated the ide option to use the default open in browser #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2016

Conversation

jeremyFreeAgent
Copy link
Contributor

@javiereguiluz
Copy link
Member

I like this proposal because this is the only value that will work for everyone. Thanks @jeremyFreeAgent

@jeremyFreeAgent
Copy link
Contributor Author

You should thank @nicolas-grekas because he is the one who told me there was the ide option set in the symfony-demo ;)

# and any custom configuration string, such as: "phpstorm://open?file=%%f&line=%%l"
# The 'ide' option turns all of the file paths in an exception page
# into clickable links that open the given file using your favorite IDE.
# Supported values are 'phpstorm', 'sublime', 'textmate', 'macvim' and 'emacs'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably explain the null value here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@sargath
Copy link

sargath commented Oct 25, 2016

Bare in mind that the user should have configured a link handler in his browser to open up those -
http://davidbu.ch/mann/blog/2014-05-06/open-php-stack-trace-links-phpstorm.html

Not every OS can handle this by its own.

@bocharsky-bw
Copy link
Contributor

I'd like to promote PhpStorm here since it's cross-platform and it has a nice Symfony plugin. Obviously, it's simply the best IDE for PHP apps and especially for Symfony apps.

@javiereguiluz
Copy link
Member

Let's merge this because Symfony 3.2 has already been released and using "null" in this option is now the default value. Thanks @jeremyFreeAgent!

@javiereguiluz javiereguiluz merged commit 2ee69c6 into symfony:master Dec 14, 2016
javiereguiluz added a commit that referenced this pull request Dec 14, 2016
…r (jeremyFreeAgent, javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Updated the ide option to use the default open in browser

Related to symfony/symfony#19973

Commits
-------

2ee69c6 Added help about the framework.ide null value behaviour
3f4fcc7 Updated the help note about framework.ide
338e423 Updated the ide option to use the default open in browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants