Fix translating "limit" variable: add extra spaces #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bocharsky-bw good catch! I was wondering if this could be added to the proposed Xliff linter (symfony/symfony#21578) but since the placeholder wrapper is configurable (it can be {{ ... }}, or % ... %, etc.) this won't be easy .... or even impossible! |
javiereguiluz
added a commit
that referenced
this pull request
Feb 14, 2017
…y-bw)
This PR was merged into the master branch.
Discussion
----------
Fix translating "limit" variable: add extra spaces
`{{limit}}` not translated at all.
Commits
-------
55aa721 Fix translating limit variable: add extra spaces
you don't even need a delimiter (even though it would make maintaining translations a huge pain). Symfony just replaces the string passed a placeholder, without caring about its content. You could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{limit}}not translated at all.