Fix DateTimePicker widget #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit into symfony:master from yceruto:fix_datetimepicker

Oct 19, 2018

Member

yceruto commented Oct 19, 2018 •

edited

Loading

As spotted here symfony/symfony#28723 (comment) we need to disable html5 to use a type="text" input and make it work again.

before	after


          Fix DateTimePicker widget

a556025

javiereguiluz added FINISHED bug labels

javiereguiluz merged commit a556025 into symfony:master

javiereguiluz added a commit that referenced this pull request


          bug #877 Fix DateTimePicker widget (yceruto)

ee62dcd

This PR was merged into the master branch.

Discussion
----------

Fix DateTimePicker widget

As spotted here symfony/symfony#28723 (comment) we need to disable `html5` to use a `type="text"` input and make it work again.

| before | after |
| --- | --- |
| ![wrong_datepicker](https://user-images.githubusercontent.com/2028198/47217570-d05a9880-d376-11e8-9e3a-116769569f22.png) | ![correct_datepicker](https://user-images.githubusercontent.com/2028198/47217582-d6e91000-d376-11e8-9fb7-86384c57ebbb.png) |

Commits
-------

a556025 Fix DateTimePicker widget

Member

javiereguiluz commented Oct 19, 2018

Thanks Yonel! I added a comment explaining why we need this option: e5c8d21

yceruto deleted the fix_datetimepicker branch

October 19, 2018 13:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels