Return html from node + removing forcing charset #8
Conversation
It's seems like it was left over from testing
| @@ -94,7 +94,6 @@ public function addContent($content, $type = null) | |||
| return null; | |||
| } | |||
|
|
|||
| $charset = 'ISO-8859-1'; | |||
There was a problem hiding this comment.
This is done on purpose as this is the default behavior of browsers.
There was a problem hiding this comment.
It just seems that there is no way to change $charset to UTF-8 if need be. Is there a way that I am not aware of? I am fetching some HTML from an UTF-8 page and returning a the contents of a div. Although later the default charset in the addHtmlContent function is UTF-8 it seems that it's being forced to ISO-8859-1 in the addContent function.
There was a problem hiding this comment.
Hi @fabpot, do you have a reference for ISO-8859-1 still being the default in modern browsers?
I think this should at least be documented, especially as like @radupb said it's not consistent with the defaults for addHtmlContent and addXmlContent. Would you be willing to accept a PR in this direction?
There was a problem hiding this comment.
@julien-c Could you check the default in modern browsers? Depending on what you find, I would accept to change the default to UTF-8. And of course, adding a piece of documentation about this decision would be good too.
|
Closing in favor of symfony/symfony#7750 |
Hello Fabien,
This is my first ever pull request so please excuse if I get something wrong.
Please accept these changes to the default Crawler class:
Thanks for accepting my requests
... and for amazing Symfony2