Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 91df8ee
Choose a base ref
...
head repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 078a6f1
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Feb 26, 2025

  1. [Mailer] fix multiple transports default injection

    @fkropfhamer @fabpot
    fkropfhamer authored and fabpot committed Feb 26, 2025
    Configuration menu
    Copy the full SHA
    33b50cb View commit details
    Browse the repository at this point in the history

  2. [Messenger] Filter out non-consumable receivers when registering `Con… 

    …sumeMessagesCommand`
    @wazum @fabpot
    wazum authored and fabpot committed Feb 26, 2025
    Configuration menu
    Copy the full SHA
    c796e22 View commit details
    Browse the repository at this point in the history

  3. bug #59198 [Messenger] Filter out non-consumable receivers when regis… 

    …tering `ConsumeMessagesCommand` (wazum)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Messenger] Filter out non-consumable receivers when registering `ConsumeMessagesCommand`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #51556
| License       | MIT

This pull request enhances the `MessengerPass` in the Symfony Framework Bundle to automatically filter out non-consumable receivers when registering the `ConsumeMessagesCommand`. The key changes are:

The FrameworkExtension has been updated to mark the "sync" transport as non-consumable by default, without requiring the user to explicitly set the `is_consumable` attribute.

The `MessengerPass` then checks the `is_consumable` attribute on the `messenger.receiver` tags. If the attribute is set to `false`, the receiver is considered non-consumable and will not be added to the list of receivers for the consume command.
If there is only one consumable receiver, the consume command will automatically use that receiver without prompting the user to select one (I added this as a separate commit if this is too implicit).

These changes improve the user experience by removing unnecessary (and non-functioning) options.

This is my first pull request for the _Symfony_ project, so please let me know what I can improve.

Commits
-------

34c7e6f1902 [Messenger] Filter out non-consumable receivers when registering `ConsumeMessagesCommand`
    @fabpot
    fabpot committed Feb 26, 2025
    Configuration menu
    Copy the full SHA
    078a6f1 View commit details
    Browse the repository at this point in the history
Loading