Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.17
Choose a base ref
...
head repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.4.18
Choose a head ref
  • 9 commits
  • 13 files changed
  • 5 contributors

Commits on Dec 11, 2024

  1. Configuration menu
    Copy the full SHA
    bfd1cf7 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2025

  1. bug #59188 [HttpClient] Fix reset() not called on decorated clients…

    … (HypeMC)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] Fix `reset()` not called on decorated clients
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | -
    | License       | MIT
    
    This was broken in #49513 for the main HTTP client and, as far as I can tell, never worked for scoped clients. The problem is that some decorator clients, like the `ThrottlingHttpClient`, have their own `reset()` method, which never gets called when using the `services_resetter` service. Scoped clients don't decorate the main one but instead use it as a dependency.
    
    Commits
    -------
    
    8f5f98a5631 [HttpClient] Fix reset not called on decorated clients
    fabpot committed Jan 2, 2025
    Configuration menu
    Copy the full SHA
    86f4863 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2025

  1. Configuration menu
    Copy the full SHA
    66b7df1 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2025

  1. Configuration menu
    Copy the full SHA
    45e3acf View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2025

  1. [FrameworkBundle] Fix patching refs to the tmp warmup dir in files ge…

    …nerated by optional cache warmers
    nicolas-grekas committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    5791a99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f14292b View commit details
    Browse the repository at this point in the history
  3. bug #59581 [Cache] Don't clear system caches on cache:clear (nicola…

    …s-grekas)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [Cache] Don't clear system caches on `cache:clear`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #59445
    | License       | MIT
    
    As spotted by `@MatTheCat` in symfony/symfony#59445 (comment), non-optional cache warmers currently cannot use any cache pools derived from the `cache.system` one.
    
    The reason is that when running `cache:clear` with no `var/cache` folder, we skip running those cache warmers since they already ran to execute the command, but we still call the cache clearer service, which empties system pools at the moment, annihilating anything non-optional cache warmers put in these pools.
    
    I propose to fix this by just not clearing cache pools derived from the system pool anymore. System pools are meant to we stored in the `kernel.cache_dir` anyway, so they're already cleared when `cache:clear` empties that folder.
    
    Commits
    -------
    
    8e820561295 [Cache] Don't clear system caches on cache:clear
    nicolas-grekas committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    7e18b72 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. Configuration menu
    Copy the full SHA
    132ab27 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. Configuration menu
    Copy the full SHA
    91df8ee View commit details
    Browse the repository at this point in the history
Loading