Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.2.0-RC1
Choose a base ref
...
head repository: symfony/framework-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.2.0
Choose a head ref
  • 7 commits
  • 9 files changed
  • 4 contributors

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    3bf0083 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. bug #58834 [FrameworkBundle] ensure validator.translation_domain pa…

    …rameter is always set (xabbuh)
    
    This PR was merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] ensure `validator.translation_domain` parameter is always set
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #58833
    | License       | MIT
    
    Commits
    -------
    
    67d085415a8 ensure that the validator.translation_domain parameter is always set
    nicolas-grekas committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e1fe039 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    f954349 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. [FrameworkBundle] Don't auto-register form/csrf when the correspondin…

    …g components are not installed
    nicolas-grekas committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    15df69b View commit details
    Browse the repository at this point in the history
  2. Revert "bug #58937 [FrameworkBundle] Don't auto-register form/csrf wh…

    …en the corresponding components are not installed (nicolas-grekas)"
    
    This reverts commit 552f7749d2b66485eb424af656827a0818c5bc4f, reversing
    changes made to e2f2a967158182109faa233b37f26687f6092a96.
    nicolas-grekas committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    eca6e49 View commit details
    Browse the repository at this point in the history
  3. Revert "[FrameworkBundle] Deprecate making cache.app adapter taggable"

    This reverts commit eed5b284618ec95eedbc376fb140b8fc24619372.
    keulinho committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    98aa662 View commit details
    Browse the repository at this point in the history
  4. bug #58950 [FrameworkBundle] Revert " Deprecate making cache.app ad…

    …apter taggable" (keulinho)
    
    This PR was merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Revert " Deprecate making `cache.app` adapter taggable"
    
    This reverts commit eed5b284618ec95eedbc376fb140b8fc24619372.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix symfony/symfony#58790
    | License       | MIT
    
    As discussed in former PR the deprecation was wrong, and trying to solve the deprecation will lead in errors.
    Refer to symfony/symfony#58830 for detailed analysis.
    
    [according to the creator](symfony/symfony#58830 (comment)) of the original issue the behaviour that is making problems is actually covered by tests, so I'm not sure how to proceed, but the deprecation is clearly wrong and should not make it to 7.2!
    
    Commits
    -------
    
    25f0925d9d2 Revert "[FrameworkBundle] Deprecate making `cache.app` adapter taggable"
    nicolas-grekas committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a8d0da4 View commit details
    Browse the repository at this point in the history
Loading