-
-
Notifications
You must be signed in to change notification settings - Fork 431
Add return types to generated guard authenticators #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The title of the PR does not describe at all what it does... What it does is adding return types to the generated guard authenticators (for forward-compatibility with Symfony 5) |
Thank you @stof for the explanation. Purely regarding Symfony, return types won't be enforced in 5.0 (see symfony/symfony#33236) and deprecation warnings may start in 5.1, but I'm not totally sure if they will match this PR (for instance, If we look at this purely from a CS perspective, having return types is nice - as long as Symfony interfaces does not break those later (6.x ?). What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The earlier apps move to use return types the better.
Are we ok @romaricdrigon ? |
Closing as MakerBundle does not support Guard Authentication anymore. Types have been gradually added in w/ the new security system. Thanks for the work on this @LeJeanbono - I wish we could have gotten to this sooner! |
You're welcome !! |
No description provided.