replaced Generator by EntityClassGenerator in MakerResetPassword #589
Conversation
…y ClassSourceManipulator
…y ClassSourceManipulator
…y ClassSourceManipulator
…y ClassSourceManipulator
…y ClassSourceManipulator
| @@ -0,0 +1,14 @@ | |||
| # In all environments, the following files are loaded if they exist, | |||
There was a problem hiding this comment.
I think you may have accidentally committed this .env file.
…y ClassSourceManipulator
|
PHP-CS-Fixer is failing in CI, perhaps run |
| @@ -0,0 +1,14 @@ | |||
| # In all environments, the following files are loaded if they exist, | |||
composer.json
Outdated
| "symfony/phpunit-bridge": "^4.3|^5.0", | ||
| "symfony/phpunit-bridge": "^5.1@dev", |
There was a problem hiding this comment.
Why the change in version constraints? We may want to leave this at ^4.3|^5.0. minimum-stability: dev will use the latest dev releases.
composer.json
Outdated
| @@ -14,13 +14,15 @@ | |||
| "minimum-stability": "dev", | |||
| "require": { | |||
| "php": "^7.0.8", | |||
| "doctrine/annotations": "^1.11@dev", | |||
There was a problem hiding this comment.
I think this may have been added by accident. But I could be mistaken. Either way, requiring @dev would be wise here, as app in production would then be forced to use unstable branches. Same for symfony/flex
There was a problem hiding this comment.
Yes, sorry. i am looking for fixing all theses errors, it is my first contribution to a collectif project i am a bit lost...
There was a problem hiding this comment.
hey no problem, if you have any questions feel free to DM on slack jrushlow
…e, modify ClassSourceManipulator" This reverts commit e86baed.
…y ClassSourceManipulator
|
Mishandling, major conflicts. |
…akerResetPassword (jeanMarcelMichelet, weaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- (Update #589) Replace Generator by EntityClassGenerator in MakerResetPassword **UPDATE PULL REQUEST #589** Q | A -- | -- Branch? | master Bug fix? | no New feature? | - yes (internal) Deprecations? | - no Tickets | - no License | MIT Doc PR | - no need At the request of Ryan Weaver. I replaced the use of Generator by EntityClassGenerator. We then needed to use ClassSourceManipulator and i propose to add 3 methods to this class, tests included. $manipulator->clearClassNodeStmts() Very short method to remove all Node\Stmts in the class and update the source code. $manipulator->addTrait() Add a use Trait; at first in the class. $manipulator->addConstructor() Is a shortcut to add a constructor in the right place. I also propose to add two optional parameters to the $manipulator->addMethodBuilder() method: array $params = [], string $methodBody = null; Allowing to build methods more directly when needed. Commits ------- 43ebb4e Updating test 6fe4061 removing part of a test that is non-essential and causing problems currently 5355556 updating make-reset password to use manipulator
At the request of Ryan Weaver.
I replaced the use of
GeneratorbyEntityClassGenerator.We then needed to use
ClassSourceManipulatorand i propose to add 3 methods to this class, tests included.$manipulator->clearClassNodeStmts()Very short method to remove all
Node\Stmtsin the class and update the source code.$manipulator->addTrait()Add a
use Trait;at first in the class.$manipulator->addConstructor()Is a shortcut to add a constructor in the right place.
I also propose to add two optional parameters to the
$manipulator->addMethodBuilder()method:array $params = [], string $methodBody = null;Allowing to build methods more directly when needed.