[ci] handle new 5.4 branch & make dev tests green #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
commented
Jul 19, 2021
| * some symfony components use psr/log ^1 || ^2 || ^3 | ||
| * once doctrine/migrations supports psr log >= 2, this line can be removed. | ||
| */ | ||
| ->addExtraDependencies('psr/log:^1.1.4') |
There was a problem hiding this comment.
@weaverryan need to make sure im not missing something here - w/o this "fix" we get the following in CI and locally against PHP 8 dev tests. See the description in the PR comments for a better explination
https://github.com/symfony/maker-bundle/runs/3099977944
1) Symfony\Bundle\MakerBundle\Tests\Maker\MakeMigrationTest::testExecute with data set "migration_with_changes" (Symfony\Bundle\MakerBundle\Test\MakerTestDetails Object (...))
Exception: Error running command: "composer require migrations doctrine/orm". Output: "". Error: "Using version ^3.1 for doctrine/doctrine-migrations-bundle
Using version ^2.9 for doctrine/orm
composer.json has been updated
Running composer update doctrine/doctrine-migrations-bundle doctrine/orm
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "5.4.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- doctrine/doctrine-migrations-bundle[3.1.0, ..., 3.1.1] require doctrine/migrations ^3.1 -> satisfiable by doctrine/migrations[3.1.0, ..., 3.3.x-dev].
- doctrine/doctrine-migrations-bundle[3.1.x-dev, ..., 3.2.x-dev] require doctrine/migrations ^3.2 -> satisfiable by doctrine/migrations[3.2.0, 3.2.x-dev, 3.3.x-dev].
- doctrine/migrations[3.1.0, ..., 3.3.x-dev] require psr/log ^1.1.3 -> found psr/log[1.1.3, 1.1.4] but the package is fixed to 2.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
- Root composer.json requires doctrine/doctrine-migrations-bundle ^3.1 -> satisfiable by doctrine/doctrine-migrations-bundle[3.1.0, 3.1.1, 3.1.x-dev, 3.2.x-dev].
Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
Installation failed, reverting composer.json and composer.lock to their original content.
"
/var/htdocs/src/Test/MakerTestProcess.php:51
/var/htdocs/src/Test/MakerTestEnvironment.php:154
/var/htdocs/src/Test/MakerTestCase.php:55
/var/htdocs/src/Test/MakerTestCase.php:33
There was a problem hiding this comment.
No, I think this is correct. We need to watch doctrine/migrations#1184 and remove this when that's merged and there's a tag.
|
Thank you Jesse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.xbranch anymore onsymfony/symfony- let's use thedevversion specified inversions.jsonin place of the5.xbranch.SYMFONY_REQUIREenv param in CI overrides the stability version specified for the run, resulting in a mixed set of versioned packages for each test. e.g.symfony/http === v5.3.0&&symfony/twig-bridge === v5.4.x-deveven thoughSYMFONY_SKELETON_STABILITY=devis set.psr/log^1 || ^2 || ^3butdoctrine/migrationsstill uses^1. For migrations tests, becausedoctrine/ormis required after the skeleton has been built, there is a version conflict w/ the locked,psr/log:2.0anddoctrine/migrations. Callingpsr/log:^1.1.4resolves this issue and allows the tests to run.contains
@legacytags for internal use:psr/log:^1.1.4as extraDependency inMakeMigrationsTestonce Allowpsr/log2 and 3 doctrine/migrations#1184 is merged, tagged, and released.