Fix the name of arguments for PHP 8 #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
commented
Oct 1, 2020
src/Php70/bootstrap.php
Outdated
| function preg_replace_callback_array(array $patterns, $subject, $limit = -1, &$count = 0) { return p\Php70::preg_replace_callback_array($patterns, $subject, $limit, $count); } | ||
| /** | ||
| * $flags is not supported. | ||
| */ | ||
| function preg_replace_callback_array(array $pattern, $subject, $limit = -1, &$count = 0, $flags = null) { return p\Php70::preg_replace_callback_array($pattern, $subject, $limit, $count); } |
There was a problem hiding this comment.
PHPs preg_replace_callback_array has a $flags argument, but the polyfill doesn't. so I added it. this would work the same.
Adding support for $flags is unrelated to this PR.
azjezz
commented
Oct 1, 2020
da8aa9f to
e34e94a
Compare
|
we would probably have to do another round once PHP 8 is released, as more functions are being updated ATM. |
This was referenced Oct 15, 2020
e34e94a to
f75e14e
Compare
|
Thank you @azjezz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHP 8 coming, we need to have function/methods parameters names consistent between polyfills and the original implementations.
I'm not sure if this is all of it yet.
see:
php/php-tasks#23
php/php-tasks#16