Skip to content

Test with PHP 7.1 + minor fixes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2016
Merged

Test with PHP 7.1 + minor fixes #69

merged 2 commits into from
Aug 23, 2016

Conversation

nicolas-grekas
Copy link
Member

No description provided.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Aug 17, 2016 •
edited
Loading

@ChadSikorra @csarrazi FYI, PHP 7.1 fixed encoding leading/trailing space and carriage returns for DN. I think we should only polyfill the correct behavior. This PR does just that, with an adaptive test case.

@ChadSikorra
Copy link
Contributor

Good catch. I forgot to open an issue for polyfill after I sent the PR to fix that for PHP :/

@nicolas-grekas nicolas-grekas merged commit a2d2021 into symfony:master Aug 23, 2016
nicolas-grekas added a commit that referenced this pull request Aug 23, 2016
@nicolas-grekas
bug #69 Test with PHP 7.1 + minor fixes (nicolas-grekas)
2e13b98 
This PR was merged into the 1.2-dev branch.

Discussion
----------

Test with PHP 7.1 + minor fixes

Commits
-------

a2d2021 Revert "bug #14 ldap_escape does not encode leading/trailing spaces. (ChadSikorra)"
2e960f0 Test with PHP 7.1 + minor fixes
@nicolas-grekas nicolas-grekas deleted the fix branch August 23, 2016 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @ChadSikorra