Skip to content

fix conversion for https requests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

4rthem
Copy link

@4rthem 4rthem commented Apr 2, 2020

HTTPS requests were not correctly converted.

@nicolas-grekas
Copy link
Member

Thank you @4rthem.

@nicolas-grekas nicolas-grekas merged commit 1309b64 into symfony:master Jun 13, 2020
nicolas-grekas added a commit that referenced this pull request Jun 25, 2020
…ory (mleczakm)

This PR was merged into the 2.0-dev branch.

Discussion
----------

Fix populating default port and headers in HttpFoundationFactory

These are few dirty hacks which are required to get symfony up and running as Roadrunner psr7 worker:
 - overriding headers need to be removed to be able to send basic auth headers.
 - setting `$_SERVER['https']` to true is required for properly handling non-proxied requests, handled with encryption directly from Roadrunner - same as #77
 - setting default server port fixes error with interpreting no port defined in url as `0`

Commits
-------

4f30401 Fix populating default port and headers in HttpFoundationFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants