Added .travis.yml #4
Conversation
|
ping @nicolas-grekas |
| matrix: | ||
| include: | ||
| - php: 5.3 | ||
| env: COMPOSER_FLAGS="--prefer-lowest" |
There was a problem hiding this comment.
--prefer-lowest needs --prefer-stable also, so you don't test with alpha/beta versions
imo, the best practice is to combine -prefer-lowest with the highest PHP version, so that you're sure that your lowest deps still work with the latest PHP
|
I think you could set COMPOSER_ROOT_VERSION for better reliability of deps |
|
@iltar can you finish this ? |
|
@fabpot please enable Travis on the repo (configuring it to skip builds which don't have a config file) |
|
OK, it is actually enabled. |
| - php: 5.3 | ||
| env: COMPOSER_FLAGS="--prefer-lowest" | ||
| - php: 5.4 | ||
| - php: 5.5 |
There was a problem hiding this comment.
I would keep them included using the normal way to build the matrix when there is nothing special to set, as done in MonologBundle: https://github.com/symfony/monolog-bundle/blob/master/.travis.yml
|
@iltar I suggest you to inspire you from the MonologBundle one (notice that the composer.json does not have |
|
Alright, I will update the PR tomorrow morning when I have some time. |
|
@stof I have taken the monolog-bundle as example, but made a minor modification to the versions tested as I got version conflicts with 2.7/2.8 and removed 2.3. |
| install: | ||
| - composer update $COMPOSER_FLAGS | ||
|
|
||
| script: phpunit -v --coverage-text |
There was a problem hiding this comment.
I don't think we should run each job with code coverage enabled. Having one dedicated coverage job (if we really want one) should be enough. The other advantage of that is that we could also disable Xdebug for all other jobs.
There was a problem hiding this comment.
I don't mind disabling it for all, not sure how important coverage is tbh. How would I turn off xdebug?
There was a problem hiding this comment.
for example, see https://github.com/symfony/symfony/blob/master/.travis.yml#L38
|
@xabbuh this PR has been open for a while, back then there were no branches for different version. I suppose the master is 3.0 just like with the other versions. Maybe I should open a PR for 2.7, have it fixed there and have that merged into 2.8 and then 3.0 instead? |
|
@iltar the 2.7 branch is still the automatic subtree split, so you should not make any change in it. 2.8 is the right target |
|
@stof so would I do best to close this one and reopen it against 2.8? I'm not sure what the best flow is here but I thought it was merging into the lowest possible version and merging that into higher versions. |
|
@iltar This is open against the |
|
@xabbuh ah my bad, got confused because of 2.7 |
|
Should we use the PHPUnit version provided by Travis or should we choose our own to have a better control which version is used to execute tests? |
|
ping, what's the status for this? |
|
I guess we should also use the |
|
@xabbuh this is not strictly necessary, as security-acl does not depend on Yaml and so does not care if PHPUnit brings the 3.1 version all the time currently. |
|
True, but what if we do use the wrapper just for consistency? |
|
Closing in favor of #66. |
Same
.travis.ymlas I've used for the AclBundle, except that I've added 5.3 and 5.4.