Declare incompatibility with symfony/security-core 6
#97
Conversation
Signed-off-by: Alexander M. Turek <me@derrabus.de>
|
Unfortunately, doing this will break the symfony/symfony CI as it requires this component. (we did this just before we made the previous release, which you corrected swiftly in #92 ) |
|
We'd better remove the return types on branch 6.0 I suppose. |
|
Maybe I'm missing something, but doesn't that mean that we must remove return types from all methods that are in classes that are not internal or final? That would be a real bummer... |
|
See my monolog on the topic at symfony/symfony#42496 :) |
|
Well, for this library, it's actually one (!) method that causes us trouble. I'm convinced we can manage that without reverting every return type we've added so far. 😱 |
|
We'd remove the return type only from |
|
This PR was merged into the 6.0 branch. Discussion ---------- [Security] Relax return type on VoterInterface | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | symfony/security-acl#97 (comment) | License | MIT | Doc PR | N/A Commits ------- c91712c [Security] Relax return type on VoterInterface
|
Closing because this has been resolved in Symfony. |
|
Linking to symfony/symfony#43021 for history. |
On the 6.0 branch,
symfony/security-corehas added return type declarations to theVoterInterface. Our implementationAclVoteris incompatible which is why our high-deps CI job is currently failing.Since this incompatibility is not trivial to fix in a backwards-compatible manner, I propose to remove the 6.0 branch from the list of compatible versions.