Fix encryption option when using env variable #177

mykiwi · 2017-05-31T15:52:41Z

Related to #170

nicolas-grekas · 2017-05-31T16:07:22Z

DependencyInjection/SwiftmailerTransportFactory.php

+     */
+    public static function validateEncryption($encryption)
+    {
+        if (!in_array($encryption, array('tls', 'ssl', null))) {


missing "true" as last arg to in_array

nicolas-grekas

👍

fabpot · 2017-06-01T18:04:37Z

Thank you @mykiwi.

This PR was merged into the 3.0-dev branch. Discussion ---------- Allow env values for auth_mode This is a follow-up to #177 which allows to use env parameters for `auth_mode` Commits ------- dbbf420 Allow env values for auth_mode

mauricios · 2018-12-06T01:01:51Z

How to disable encryption using environment variable?.

Environment variables are not nullable (they are strings by design), there is no way to disable or override encryption using environment variables. I want to keep my default value as ssl for Production, but I want to disable for a development where I use a local SMTP that does not support encryption.

nicolas-grekas reviewed May 31, 2017

View reviewed changes

mykiwi added 2 commits May 31, 2017 19:47

fix encryption option when using env variable

9fc9f8c

update tests

f9a82c8

mykiwi force-pushed the fix-encryption-when-using-env-variable branch from eb26322 to f9a82c8 Compare May 31, 2017 18:01

nicolas-grekas approved these changes Jun 1, 2017

View reviewed changes

fabpot closed this in 9ddeacb Jun 1, 2017

pierredup mentioned this pull request Jun 8, 2017

Allow env values for auth_mode #180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix encryption option when using env variable #177

Fix encryption option when using env variable #177

mykiwi commented May 31, 2017

nicolas-grekas May 31, 2017

nicolas-grekas left a comment

fabpot commented Jun 1, 2017

mauricios commented Dec 6, 2018 •

edited

Loading

Fix encryption option when using env variable #177

Fix encryption option when using env variable #177

Conversation

mykiwi commented May 31, 2017

nicolas-grekas May 31, 2017

Choose a reason for hiding this comment

nicolas-grekas left a comment

Choose a reason for hiding this comment

fabpot commented Jun 1, 2017

mauricios commented Dec 6, 2018 • edited Loading

mauricios commented Dec 6, 2018 •

edited

Loading