minor #60356 don't hardcode OS-depending constant values (xabbuh)

fabpot · fabpot · commit 00697342a443 · 2025-05-07T08:23:32.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- don't hardcode OS-depending constant values | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The values of the `SIG*` constants depend on the OS. For example, on macOS the value of the `SIGSYS` constant is 12 and not 31 making the test added in #60168 fail. Commits ------- 3213d88 don't hardcode OS-depending constant values
diff --git a/src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php b/src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php
@@ -18,17 +18,21 @@ class SignalMapTest extends TestCase
 {
     /**
      * @requires extension pcntl
-     *
-     * @testWith [2, "SIGINT"]
-     *           [9, "SIGKILL"]
-     *           [15, "SIGTERM"]
-     *           [31, "SIGSYS"]
+     * @dataProvider provideSignals
      */
     public function testSignalExists(int $signal, string $expected)
     {
         $this->assertSame($expected, SignalMap::getSignalName($signal));
     }
 
+    public function provideSignals()
+    {
+        yield [\SIGINT, 'SIGINT'];
+        yield [\SIGKILL, 'SIGKILL'];
+        yield [\SIGTERM, 'SIGTERM'];
+        yield [\SIGSYS, 'SIGSYS'];
+    }
+
     public function testSignalDoesNotExist()
     {
         $this->assertNull(SignalMap::getSignalName(999999));
