minor #57801 [Cache] Use tempnam() instead of uniquid() to produce a temporary file (derrabus)

xabbuh · xabbuh · commit 04f9e6dc07cc · 2024-07-23T08:01:38.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [Cache] Use tempnam() instead of uniquid() to produce a temporary file | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? |no | Deprecations? | no | Issues | Part of #57588 | License | MIT Commits ------- 3465a2b [Cache] Use tempnam() instead of uniquid()
diff --git a/src/Symfony/Component/Cache/Adapter/PhpArrayAdapter.php b/src/Symfony/Component/Cache/Adapter/PhpArrayAdapter.php
@@ -41,7 +41,7 @@ class PhpArrayAdapter implements AdapterInterface, CacheInterface, PruneableInte
     private static array $valuesCache = [];
 
     /**
-     * @param string           $file         The PHP file were values are cached
+     * @param string           $file         The PHP file where values are cached
      * @param AdapterInterface $fallbackPool A pool to fallback on when an item is not hit
      */
     public function __construct(
@@ -321,7 +321,7 @@ public function warmUp(array $values): array
 
         $dump .= "\n], [\n\n{$dumpedValues}\n]];\n";
 
-        $tmpFile = uniqid($this->file, true);
+        $tmpFile = tempnam(dirname($this->file), basename($this->file));
 
         file_put_contents($tmpFile, $dump);
         @chmod($tmpFile, 0666 & ~umask());
