feature #30645 Alias for each assets package (gpenverne)

fabpot · fabpot · commit 0c02a40d72cd · 2019-03-27T07:44:58.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- Alias for each assets package | Q | A | ------------- | --- | Branch? | master  | Bug fix? | no | New feature? | yes  | BC breaks? | ?  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets |  | License | MIT | Doc PR |  Add autowiring by type + name on assets packages ```yaml framework: assets: packages: xxx: base_urls: 'xxxx' ``` ```php <?php class MyService { private $xxxPackage; public function __construct(PackageInterface $xxxPackage) { $this->xxxPackage = $xxxPackage; ... } public function myMethod(): string { return $this->xxxPackage->getUrl('some-image.png'); } } ``` instead of: ```php <?php class MyService { private $packages; public function __construct(Packages $packages) { $this->packages = $packages; ... } public function myMethod(): string { return $this->packages->getPackage('xxx')->getUrl('some-image.png'); } } ``` Commits ------- e8b9856 Alias for each assets package
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -23,6 +23,7 @@
 use Symfony\Bundle\FrameworkBundle\Routing\AnnotatedRouteControllerLoader;
 use Symfony\Bundle\FrameworkBundle\Routing\RedirectableUrlMatcher;
 use Symfony\Bundle\FullStack;
+use Symfony\Component\Asset\PackageInterface;
 use Symfony\Component\BrowserKit\AbstractBrowser;
 use Symfony\Component\Cache\Adapter\AbstractAdapter;
 use Symfony\Component\Cache\Adapter\AdapterInterface;
@@ -996,6 +997,7 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co
             }
 
             $container->setDefinition('assets._package_'.$name, $this->createPackageDefinition($package['base_path'], $package['base_urls'], $version));
+            $container->registerAliasForArgument('assets._package_'.$name, PackageInterface::class, $name.'.package');
             $namedPackages[$name] = new Reference('assets._package_'.$name);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`use Symfony\Bundle\FrameworkBundle\Routing\AnnotatedRouteControllerLoader;`
`24`	`24`	`use Symfony\Bundle\FrameworkBundle\Routing\RedirectableUrlMatcher;`
`25`	`25`	`use Symfony\Bundle\FullStack;`
	`26`	`+use Symfony\Component\Asset\PackageInterface;`
`26`	`27`	`use Symfony\Component\BrowserKit\AbstractBrowser;`
`27`	`28`	`use Symfony\Component\Cache\Adapter\AbstractAdapter;`
`28`	`29`	`use Symfony\Component\Cache\Adapter\AdapterInterface;`
`@@ -996,6 +997,7 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co`
`996`	`997`	`}`
`997`	`998`
`998`	`999`	`$container->setDefinition('assets._package_'.$name, $this->createPackageDefinition($package['base_path'], $package['base_urls'], $version));`
	`1000`	`+ $container->registerAliasForArgument('assets._package_'.$name, PackageInterface::class, $name.'.package');`
`999`	`1001`	`$namedPackages[$name] = new Reference('assets._package_'.$name);`
`1000`	`1002`	`}`
`1001`	`1003`