-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Alias for each assets package #30645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:master
from
gpenverne:improvement-alias-for-each-assets-package
Mar 27, 2019
Merged
Alias for each assets package #30645
fabpot
merged 1 commit into
symfony:master
from
gpenverne:improvement-alias-for-each-assets-package
Mar 27, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice, I already needed this in the past. |
1d8767e
to
d89e46a
Compare
d89e46a
to
e8b9856
Compare
nicolas-grekas
approved these changes
Mar 25, 2019
@gpenverne Can you submit a PR on the docs? |
fabpot
approved these changes
Mar 25, 2019
Thank you @gpenverne. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- Alias for each assets package | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | ? <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> Add autowiring by type + name on assets packages ```yaml framework: assets: packages: xxx: base_urls: 'xxxx' ``` ```php <?php class MyService { private $xxxPackage; public function __construct(PackageInterface $xxxPackage) { $this->xxxPackage = $xxxPackage; ... } public function myMethod(): string { return $this->xxxPackage->getUrl('some-image.png'); } } ``` instead of: ```php <?php class MyService { private $packages; public function __construct(Packages $packages) { $this->packages = $packages; ... } public function myMethod(): string { return $this->packages->getPackage('xxx')->getUrl('some-image.png'); } } ``` Commits ------- e8b9856 Alias for each assets package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autowiring by type + name on assets packages
instead of: