minor #22224 Fix HttpCache test (chalasr)

fabpot · fabpot · commit 0d85a99e18d0 · 2017-04-03T15:52:28.000-07:00
This PR was merged into the 3.3-dev branch. Discussion ---------- Fix HttpCache test | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #22043 (comment) | License | MIT | Doc PR | n/a will make appveyor green. Commits ------- 3178f50 Fix failing HttpCache test on windows
diff --git a/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php b/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php
@@ -564,6 +564,10 @@ public function testHitsCachedResponseWithMaxAgeDirective()
 
     public function testDegradationWhenCacheLocked()
     {
+        if ('\\' === DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Skips on windows to avoid permissions issues.');
+        }
+
         $this->cacheConfig['stale_while_revalidate'] = 10;
 
         // The prescence of Last-Modified makes this cacheable (because Response::isValidateable() then).

Original file line number	Diff line number	Diff line change
`@@ -564,6 +564,10 @@ public function testHitsCachedResponseWithMaxAgeDirective()`
`564`	`564`
`565`	`565`	`public function testDegradationWhenCacheLocked()`
`566`	`566`	`{`
	`567`	`+ if ('\\' === DIRECTORY_SEPARATOR) {`
	`568`	`+ $this->markTestSkipped('Skips on windows to avoid permissions issues.');`
	`569`	`+ }`
	`570`	`+`
`567`	`571`	`$this->cacheConfig['stale_while_revalidate'] = 10;`
`568`	`572`
`569`	`573`	`// The prescence of Last-Modified makes this cacheable (because Response::isValidateable() then).`