Skip to content

Fix HttpCache test #22224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix HttpCache test #22224

merged 1 commit into from
Apr 3, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 30, 2017 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #22043 (comment)
License MIT
Doc PR n/a

will make appveyor green.

@chalasr
Copy link
Member Author

chalasr commented Mar 30, 2017

The refactoring made in #22043 is not the cause, reverting it makes this test keep failing on windows.

@marek-pietrzak-tg
Copy link
Contributor

Wouldn't be better to fix the error on Windows or create alternative test which won't break there, instead of skipping the test?

@chalasr chalasr force-pushed the skip-httpcache-win branch from fdd1002 to 98b20d5 Compare March 30, 2017 20:02
@chalasr chalasr changed the title Skip breaking test on windows Fix HttpCache test Mar 30, 2017
@chalasr chalasr force-pushed the skip-httpcache-win branch 2 times, most recently from 8af132e to 6d66ced Compare March 30, 2017 20:12
@chalasr
Copy link
Member Author

chalasr commented Mar 30, 2017

Status: needs work

@chalasr chalasr force-pushed the skip-httpcache-win branch from 6d66ced to 3178f50 Compare April 3, 2017 09:40
@chalasr
Copy link
Member Author

chalasr commented Apr 3, 2017

Spent some hours at trying to debug it and I can't find the bottleneck, so keep skipping on windows as it runs fine on other platforms.

@chalasr
Copy link
Member Author

chalasr commented Apr 3, 2017

Status: needs review

@fabpot
Copy link
Member

fabpot commented Apr 3, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 3178f50 into symfony:master Apr 3, 2017
fabpot added a commit that referenced this pull request Apr 3, 2017
@fabpot
minor #22224 Fix HttpCache test (chalasr)
0d85a99 
This PR was merged into the 3.3-dev branch.

Discussion
----------

Fix HttpCache test

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #22043 (comment)
| License       | MIT
| Doc PR        | n/a

will make appveyor green.

Commits
-------

3178f50 Fix failing HttpCache test on windows
@chalasr chalasr deleted the skip-httpcache-win branch April 3, 2017 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @marek-pietrzak-tg @fabpot @carsonbot