merged branch hason/crawler (PR #5407)

fabpot · fabpot · commit 0fc0fb3b9ca3 · 2012-10-14T11:36:44.000+02:00
This PR was merged into the master branch. Commits ------- c902966 [DomCrawler] Added ability to set file as raw path to file field Discussion ---------- [2.2][DomCrawler] Added ability to set file as raw path to file field Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT For description see #4674 (#4674 (comment)) Related PRs: Behat/MinkBrowserKitDriver#1 https://github.com/Behat/MinkGoutteDriver/pull/7 FriendsOfPHP/Goutte#77 --------------------------------------------------------------------------- by stof at 2012-10-13T21:53:27Z @fabpot anything missing here ?
diff --git a/src/Symfony/Component/DomCrawler/CHANGELOG.md b/src/Symfony/Component/DomCrawler/CHANGELOG.md
@@ -1,6 +1,12 @@
 CHANGELOG
 =========
 
+2.2.0
+-----
+
+ * added a way to set raw path to the file in FileFormField - necessary for
+   simulating HTTP requests
+
 2.1.0
 -----
 
diff --git a/src/Symfony/Component/DomCrawler/Field/FileFormField.php b/src/Symfony/Component/DomCrawler/Field/FileFormField.php
@@ -76,6 +76,16 @@ public function setValue($value)
         $this->value = array('name' => $name, 'type' => '', 'tmp_name' => $value, 'error' => $error, 'size' => $size);
     }
 
+    /**
+     * Sets path to the file as string for simulating HTTP request
+     *
+     * @param string $path The path to the file
+     */
+    public function setFilePath($path)
+    {
+        parent::setValue($path);
+    }
+
     /**
      * Initializes the form field.
      *
diff --git a/src/Symfony/Component/DomCrawler/Tests/Field/FileFormFieldTest.php b/src/Symfony/Component/DomCrawler/Tests/Field/FileFormFieldTest.php
@@ -84,4 +84,14 @@ public function testSetErrorCode()
             $this->assertTrue(true, '->setErrorCode() throws a \InvalidArgumentException if the error code is not valid');
         }
     }
+
+    public function testSetRawFilePath()
+    {
+        $node = $this->createNode('input', '', array('type' => 'file'));
+        $field = new FileFormField($node);
+        $field->setFilePath(__FILE__);
+
+        $this->assertEquals(__FILE__, $field->getValue());
+    }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -84,4 +84,14 @@ public function testSetErrorCode()`
`84`	`84`	`$this->assertTrue(true, '->setErrorCode() throws a \InvalidArgumentException if the error code is not valid');`
`85`	`85`	`}`
`86`	`86`	`}`
	`87`	`+`
	`88`	`+ public function testSetRawFilePath()`
	`89`	`+ {`
	`90`	`+ $node = $this->createNode('input', '', array('type' => 'file'));`
	`91`	`+ $field = new FileFormField($node);`
	`92`	`+ $field->setFilePath(__FILE__);`
	`93`	`+`
	`94`	`+ $this->assertEquals(__FILE__, $field->getValue());`
	`95`	`+ }`
	`96`	`+`
`87`	`97`	`}`