[2.2][DomCrawler] Added ability to set file as raw path to file field #5407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $value The value of the field | ||
| * @param Boolean $raw Set file path as string (for simulating HTTP request) | ||
| */ | ||
| public function setValue($value, $raw = false) |
There was a problem hiding this comment.
I don't like the method signature change. I would prefer to add a new method for this use case. It also makes things more explicit.
There was a problem hiding this comment.
This proposed change is very elegant, no BC and setValue($foo, true) works with (right behaviour) or without (bad behavior in some cases) this change. But I agree that it's not a nice solution. So should I leave setValue as alias for upload and create setFilePathmethod?
|
@fabpot anything missing here ? |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2012
This PR was merged into the master branch. Commits ------- c902966 [DomCrawler] Added ability to set file as raw path to file field Discussion ---------- [2.2][DomCrawler] Added ability to set file as raw path to file field Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes License of the code: MIT For description see #4674 (#4674 (comment)) Related PRs: Behat/MinkBrowserKitDriver#1 https://github.com/Behat/MinkGoutteDriver/pull/7 FriendsOfPHP/Goutte#77 --------------------------------------------------------------------------- by stof at 2012-10-13T21:53:27Z @fabpot anything missing here ?
This was referenced Oct 16, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
For description see #4674 (#4674 (comment))
Related PRs:
Behat/MinkBrowserKitDriver#1
https://github.com/Behat/MinkGoutteDriver/pull/7
FriendsOfPHP/Goutte#77