minor #17126 [Security] Run tests on all PHP versions (jakzal)

Tobion · Tobion · commit 1230eabe9aa4 · 2015-12-24T01:59:57.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [Security] Run tests on all PHP versions Symfony 2.7 supports PHP >= 5.3.9. Since #17073 was merged to 2.7 now, we need to remove the checks for 5.3.7 again. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 4bec980 [Security] Run tests on all PHP versions
diff --git a/src/Symfony/Component/Security/Core/Tests/Encoder/BCryptPasswordEncoderTest.php b/src/Symfony/Component/Security/Core/Tests/Encoder/BCryptPasswordEncoderTest.php
@@ -45,19 +45,13 @@ public function testCostInRange()
         }
     }
 
-    /**
-     * @requires PHP 5.3.7
-     */
     public function testResultLength()
     {
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(self::PASSWORD, null);
         $this->assertEquals(60, strlen($result));
     }
 
-    /**
-     * @requires PHP 5.3.7
-     */
     public function testValidation()
     {
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
@@ -76,9 +70,6 @@ public function testEncodePasswordLength()
         $encoder->encodePassword(str_repeat('a', 73), 'salt');
     }
 
-    /**
-     * @requires PHP 5.3.7
-     */
     public function testCheckPasswordLength()
     {
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);

Original file line number	Diff line number	Diff line change
`@@ -45,19 +45,13 @@ public function testCostInRange()`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`- /**`
`49`		`- * @requires PHP 5.3.7`
`50`		`- */`
`51`	`48`	`public function testResultLength()`
`52`	`49`	`{`
`53`	`50`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`
`54`	`51`	`$result = $encoder->encodePassword(self::PASSWORD, null);`
`55`	`52`	`$this->assertEquals(60, strlen($result));`
`56`	`53`	`}`
`57`	`54`
`58`		`- /**`
`59`		`- * @requires PHP 5.3.7`
`60`		`- */`
`61`	`55`	`public function testValidation()`
`62`	`56`	`{`
`63`	`57`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`
`@@ -76,9 +70,6 @@ public function testEncodePasswordLength()`
`76`	`70`	`$encoder->encodePassword(str_repeat('a', 73), 'salt');`
`77`	`71`	`}`
`78`	`72`
`79`		`- /**`
`80`		`- * @requires PHP 5.3.7`
`81`		`- */`
`82`	`73`	`public function testCheckPasswordLength()`
`83`	`74`	`{`
`84`	`75`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`