bug #24421 [Config] Fix dumped files invalidation by OPCache (nicolas-grekas)

fabpot · fabpot · commit 253cde2062af · 2017-10-04T11:52:35.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [Config] Fix dumped files invalidation by OPCache | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While demoing Flex, I've noticed that container invalidation takes a few seconds on my setup. I've debugged that down to OPcache, which serves the legacy container while it's been overridden. Let's invalidate the file explicitly when it changes. Commits ------- b1290da [Config] Fix dumped files invalidation by OPCache
diff --git a/src/Symfony/Component/Config/ConfigCache.php b/src/Symfony/Component/Config/ConfigCache.php
@@ -149,6 +149,10 @@ public function write($content, array $metadata = null)
                 // discard chmod failure (some filesystem may not support it)
             }
         }
+
+        if (\function_exists('opcache_invalidate') && ini_get('opcache.enable')) {
+            @opcache_invalidate($this->file, true);
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,10 @@ public function write($content, array $metadata = null)`
`149`	`149`	`// discard chmod failure (some filesystem may not support it)`
`150`	`150`	`}`
`151`	`151`	`}`
	`152`	`+`
	`153`	`+ if (\function_exists('opcache_invalidate') && ini_get('opcache.enable')) {`
	`154`	`+ @opcache_invalidate($this->file, true);`
	`155`	`+ }`
`152`	`156`	`}`
`153`	`157`
`154`	`158`	`/**`