[Config] Fix dumped files invalidation by OPCache #24421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Oct 4, 2017
| @@ -149,6 +149,10 @@ public function write($content, array $metadata = null) | |||
| // discard chmod failure (some filesystem may not support it) | |||
| } | |||
| } | |||
|
|
|||
| if (function_exists('opcache_invalidate') && ini_get('opcache.enable')) { | |||
chalasr
approved these changes
Oct 4, 2017
9c8fa7e to
b1290da
Compare
ogizanagi
approved these changes
Oct 4, 2017
Simperfit
approved these changes
Oct 4, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 4, 2017
…-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Config] Fix dumped files invalidation by OPCache | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While demoing Flex, I've noticed that container invalidation takes a few seconds on my setup. I've debugged that down to OPcache, which serves the legacy container while it's been overridden. Let's invalidate the file explicitly when it changes. Commits ------- b1290da [Config] Fix dumped files invalidation by OPCache
This was referenced Oct 5, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While demoing Flex, I've noticed that container invalidation takes a few seconds on my setup.
I've debugged that down to OPcache, which serves the legacy container while it's been overridden.
Let's invalidate the file explicitly when it changes.