Skip to content

Commit 2937f30

Browse files
Merge branch '4.4'
* 4.4: add yceruto as code owner of the ErrorRenderer component [HttpClient] Relax max duration test assertion Ignore ErrorHandler DebugClassLoaderTest class in PHP-CS-Fixer config
2 parents 9fcdddd + b59c865 commit 2937f30

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

.github/CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
/src/Symfony/Component/Console/Logger/ConsoleLogger.php @dunglas
33
# DependencyInjection
44
/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php @dunglas
5+
# ErrorRenderer
6+
/src/Symfony/Component/ErrorRenderer/* @yceruto
57
# Form
68
/src/Symfony/Bridge/Twig/Extension/FormExtension.php @xabbuh
79
/src/Symfony/Bridge/Twig/Form/* @xabbuh
@@ -33,6 +35,8 @@
3335
/src/Symfony/Bridge/Doctrine/PropertyInfo/* @dunglas
3436
# Serializer
3537
/src/Symfony/Component/Serializer/* @dunglas
38+
# TwigBundle
39+
/src/Symfony/Bundle/TwigBundle/ErrorRenderer/TwigHtmlErrorRenderer.php @yceruto
3640
# WebLink
3741
/src/Symfony/Component/WebLink/* @dunglas
3842
# Workflow

.php_cs.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ return PhpCsFixer\Config::create()
5151
// explicit heredoc test
5252
->notPath('Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Resources/views/translation.html.php')
5353
// explicit trigger_error tests
54-
->notPath('Symfony/Component/Debug/Tests/DebugClassLoaderTest.php')
54+
->notPath('Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php')
5555
// invalid annotations on purpose
5656
->notPath('Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php')
5757
)

src/Symfony/Component/ErrorRenderer/composer.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
"name": "Fabien Potencier",
1111
"email": "fabien@symfony.com"
1212
},
13+
{
14+
"name": "Yonel Ceruto",
15+
"email": "yonelceruto@gmail.com"
16+
},
1317
{
1418
"name": "Symfony Community",
1519
"homepage": "https://symfony.com/contributors"

src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,6 @@ public function testMaxDuration()
795795

796796
$duration = microtime(true) - $start;
797797

798-
$this->assertGreaterThanOrEqual(0.1, $duration);
799-
$this->assertLessThan(0.2, $duration);
798+
$this->assertLessThan(10, $duration);
800799
}
801800
}

0 commit comments

Comments
 (0)