Skip to content

Commit 29750e5

Browse files
committed
fix container cache key generation
If the actual class name were not taken into, we would not be able to detect inconsistencies between the different configuration formats (PHP, YAML, and XML) as the container built based on the first evaluated configuration format would be cached and reused by tests for the other formats too.
1 parent 2c43532 commit 29750e5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ protected function createContainer(array $data = array())
309309

310310
protected function createContainerFromFile($file, $data = array())
311311
{
312-
$cacheKey = md5($file.serialize($data));
312+
$cacheKey = md5(get_class($this).$file.serialize($data));
313313
if (isset(self::$containerCache[$cacheKey])) {
314314
return self::$containerCache[$cacheKey];
315315
}

0 commit comments

Comments
 (0)